Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stella-cv-fbow: new recipe #23889

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented May 6, 2024

Adds a stella-cv fork of FBoW: https://github.com/stella-cv/FBoW

FBoW (Fast Bag of Words) is an extremely optimized version of the DBoW2/DBoW3 libraries.
The library is highly optimized to speed up the Bag of Words creation using AVX,SSE and MMX instructions.

Required for packaging of https://github.com/stella-cv/stella_vslam

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the new/stella-cv-fbow branch from 0987413 to 15f1e44 Compare May 7, 2024 08:35
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this May 8, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor comment about the cmake cxx standard variable, otherwise looks good :)

recipes/stella-cv-fbow/all/conanfile.py Show resolved Hide resolved
@valgur
Copy link
Contributor Author

valgur commented May 8, 2024

Note: MSVC builds are currently skipped due to no llvm-openmp support for it. Requires #22353.

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes May 9, 2024
Co-authored-by: toge <toge.mail@gmail.com>
@valgur valgur marked this pull request as draft May 12, 2024 08:36
@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes May 16, 2024
@perseoGI
Copy link
Contributor

perseoGI commented Jun 6, 2024

Hi @valgur, is this PR still in draft? Or can we merge?

@perseoGI perseoGI self-assigned this Jun 6, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@perseoGI perseoGI requested a review from AbrilRBS June 11, 2024 12:04
@perseoGI perseoGI marked this pull request as ready for review June 11, 2024 12:07
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (1ee9bd1d37084e9eb5c523268d3036d716a5586b):

  • stella-cv-fbow/cci.20240508:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (1ee9bd1d37084e9eb5c523268d3036d716a5586b):

  • stella-cv-fbow/cci.20240508:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit c6f94bb into conan-io:master Jun 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants